[cairo] [PATCH] [ARM] too many arguments to function _pixman_image_get_solid

Soeren Sandmann sandmann at daimi.au.dk
Fri Jun 26 16:32:50 PDT 2009


> > A new pixman release 0.15.14 is now available.
> It doesn't compile for me on ARM.
> There are too many arguments to function _pixman_image_get_solid()

Yes, sorry. Apparently I broke this when changing the
FbComposeGetSolid() macro to _pixman_image_get_solid().

> I also believe it was intended fbCompositeSolidMask_nx8x8888neon and
> fbCompositeSolidMask_nx8x8888arm to bail out if fully transparent but it
> seems it was not implemented in that way.

We can't actually bail when just the alpha channel is 0. That's
because the color channels might still be non-zero, even with
premultiplication, and in that the over computation still needs to be
carried out.

> See Patch attached.

I have pushed it with the srca == 0 bits left out.


More information about the cairo mailing list