[cairo] Pixman refactoring
jeff at infidigm.net
Wed May 6 15:10:06 PDT 2009
On Tue, May 05, 2009 at 10:07:38AM +0200, Soeren Sandmann wrote:
> * Make drawable, gradient and solid fill images into objects that know
> how to produce pixels and scanlines for the rest of the
> implementation to use.
> * Move all code and tables pertaining to architecture specific fast
> paths into architecture specific files.
> * Move all C fast paths into their own file
> * Implement the composite() function in one file, rather than two.
> * Get the Render spec and pixman to largely agree with each-other
> * Reformat with consistent naming and coding style (basically the one
> described in cairo/CODING_STYLE with a few changes).
I prefer having the braces on the same line as the 'while ()' but you're
the maintainer and it's not a huge deal.
> Some of this is done already, in these branches:
> The refactor branch has code to eliminate duplicated code from the
> general compositing path. The separate-images branch branches off
> refactor and splits gradients solid fills and pixel-based images into
> their own files. There is a document in there called 'refactor' which
> contains various notes and specification drafts.
> I expect to merge the refactor branch to master soon, and the
> separate-images branch soon after that. Review and testing (especially
> if you use wfb), is appreciated.
I've had a quick look over most of both branches and what I saw looked
really good. Definitely a good cleanup. I especially like the file splits.
More information about the cairo