[cairo] [PATCH]es for pixman 0.16.0 on Solaris
M Joonas Pihlaja
jpihlaja at cc.helsinki.fi
Wed Sep 2 12:49:58 PDT 2009
On Wed, 2 Sep 2009, Soeren Sandmann wrote:
> M Joonas Pihlaja <jpihlaja at cc.helsinki.fi> writes:
> > I've attached a few patches for building pixman 0.16.0 on Solaris
> > using Sun Studio 12's C compiler. The first two seem fairly
> > straightforward if slightly ugly tweaks to me, and the last one
> > changes the default CFLAGS to be "-O -g" rather than just the "-g"
> > given to us by autoconf. I think this is a more useful default and
> > also brings it in line with the long standing autoconf default "-O2
> > -g" for gcc. If there's nothing horribly broken about these to your
> > eyes I'd like to go ahead and push them to pixman master.
> Makes sense to me. Does it make sense to add these to 0.16.2?
For the first two patches which actually make it compile, I do think
they should go into 0.16.2.
For the third one regarding optimised builds by default, well that's a
pure policy call. Personally I think that defaulting to builds with
sane optimisations turned on helps users out and follows a path of
least surprise, especially considering that pixman's configure already
turns on relevant SSE2/MMX/etc flags.
More information about the cairo