[cairo] 29e22cf38e8abc54b9dddbdeb3909d02866a82a0 - Enable component alpha on solid mask

Soeren Sandmann sandmann at daimi.au.dk
Mon Sep 14 04:51:47 PDT 2009

Hi Chris (and also the list, this time)

Thanks for adding the new test from rendercheck. That is going to be
useful. Most of the other commits look good too, but I don't
understand the component-alpha-on-solid-mask one:

@@ -159,9 +159,9 @@ general_composite_rect  (pixman_implementation_t
         fetch_src                       &&
         fetch_mask                      &&
         mask                            &&
-        mask->common.type == BITS       &&
-        mask->common.component_alpha    &&
-        PIXMAN_FORMAT_RGB (mask->bits.format);
+        mask->common.component_alpha   &&
+        (mask->common.type == SOLID ||
+        (mask->common.type == BITS && PIXMAN_FORMAT_RGB

     if (wide)

Is there any reason to believe that anyone would actually do this? It
doesn't seem useful to me. And if we are going to support component
alpha on solid images, shouldn't it also be supported on gradients?

In any case, as far as I know we have never supported this before, so
I don't think it belongs on the 0.16 branch.


More information about the cairo mailing list