[cairo] Build system b0rkage and pthread

Behdad Esfahbod behdad at behdad.org
Wed Aug 11 14:01:38 PDT 2010


Kinda in a rant mode.

Two specific issues:

  - This commit of Chris: 7f114b781f5c530d57530e5f76402e41cdabac6b
Is very wrong for many reasons, least of which because it modifies
Makefile.am.gtk-doc which we copy from gtk-doc and should not be modified.

I'm not sure why the commit was needed.  The commit message doesn't make sense
to me.

  - In configure.ac.pthread:

    * Please add "static" to all the C functions you define.

    * Use of CAIRO_CC_TRY_LINK_WITH_ENV_SILENT() in pthread check or for ANY
OTHER REASON is B0RKED.  There is no way that you can write code that does not
generate warnings with my compiler.  Just don't make such stupid assumptions.  Ok?

Right now master simply doesn't succeed configuring on my machines.  Have to
change that stupid check.

What's wrong with just checking that the linking succeeds again?

Please, please, please, avoid creative solutions to build problems.  Kick me
hard and I'll come up with a good way to do it.

End of rant mode.



More information about the cairo mailing list