[cairo] [PATCH] [cairo-gl] Use dispatch mechanism to abstract differences between GL versions (and remove GLEW)

Alexandros Frantzis alexandros.frantzis at linaro.org
Tue Dec 7 07:53:33 PST 2010


On Tue, Dec 07, 2010 at 01:38:38PM +0000, Chris Wilson wrote:
> On Tue, 7 Dec 2010 00:49:28 +0200, Alexandros Frantzis <alexandros.frantzis at linaro.org> wrote:
> > The branch has been tested successfully on Mesa on i915 (GL 1.4) and with the
> > software renderer (GL 2.1).
> > 
> > The 'gl-remove-glew' branch can be found at:
> 
> The ordering of the patches look wrong in place. Such as removing ARB glsl
> support before implementing the common code.

Yes, I thought of that when creating the patchset, but it meant that I
would need to fix some things in the ARB functions, just to completely
remove them in the next commit. Also, the code still works after this
commit, although without using the shaders for 1.x. In the end my
laziness prevailed :)

In any case, it's an easy (and sensible) change, so I can apply it this
time.

Any other suggestions about making the ordering more sensible are
welcome.

> Aside from that and the dreaded trailing whitespace issues

I will take care of this.

I will create a new branch with the changed patchset and post it here
(or do you prefer that I amend the current branch?).

Thanks,
Alexandros


More information about the cairo mailing list