[cairo] [PATCH] script: More compatible with C89 and VC++.

Bill Spitzak spitzak at gmail.com
Thu Jun 24 14:50:54 PDT 2010


I also do not see how basename has to be so complicated. You do not need 
to translate multibyte characters in order to locate '/' and ':' and 
'\\' characters. Translation to w_char and back is lossy so this is not 
a good idea!

Chris Wilson wrote:
> Can you split this up into at least two patches? Changing the structures
> over to C89 is one patch, though I mourn for the necessity. Including
> basename I would predicate on ifndef HAVE_LIBGEN_H. But are you really
> sure you want to run this utilities on Windows? Just wondering if they
> are even worth the hassle of incorporating into your build.
> -ickle
> 


More information about the cairo mailing list