[PATCH 2/2] XCB: Remove a wrong optimization

Uli Schlachter psychon at znc.in
Mon Nov 29 10:11:26 PST 2010


This thing belongs into gstate and some other commit will have to make sure
gstate does this. However, this has to make sure that source-bounded operations
still work currently which the code that is removed here doesn't do.

This fixes clear-source for xcb.

Signed-off-by: Uli Schlachter <psychon at znc.in>
---
 src/cairo-xcb-surface-render.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/src/cairo-xcb-surface-render.c b/src/cairo-xcb-surface-render.c
index 7bf9c13..a1ff799 100644
--- a/src/cairo-xcb-surface-render.c
+++ b/src/cairo-xcb-surface-render.c
@@ -1156,13 +1156,6 @@ _cairo_xcb_surface_picture (cairo_xcb_surface_t *target,
     cairo_filter_t filter;
     cairo_status_t status;
 
-    if (source->is_clear) {
-        if (source->content & CAIRO_CONTENT_ALPHA)
-	    return _cairo_xcb_transparent_picture (target);
-        else
-            return _cairo_xcb_black_picture (target);
-    }
-
     {
 	cairo_xcb_surface_t *snapshot;
 
-- 
1.7.2.3


--------------070300010402070502090409
Content-Type: application/octet-stream;
 name="0001-XCB-Fix-clip-fill-eo-nz-unbounded-tests.patch.sig"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="0001-XCB-Fix-clip-fill-eo-nz-unbounded-tests.patch.sig"

iQEcBAABCAAGBQJNC8HvAAoJECLkKOvLj8sGAD0IALT1WUhQTpCXJcGi9nptk3nW7+wkYGT1
zFsEFBz3T6QEU3PigbmGRZX4jcRm8XKfhhMXx+7IV1LGhpW3pLQxFQKwJaejToF6P6yETcBh
yisH2CIKAgz+HD6mnd2PjBJNT/NZffWXXeLVQ7KxS1UpIU9tNJ9hTqdnCvaEMazW/TFWf3E+
C6rh2hVjNvrz0swMea3up1iKWQ1SuB645BMgmfu2jIr820dEfBUIcNIG5TtcK4LMGgsVwN5c
0zHi661zSos9v88KwUIE3TzZYyl5/2hYeIRFDq9LKR1msIzIujFljHa3c6LSsfRPMnyUqQTo
7kkGFvEHSxUPa51DXciWSPU=
--------------070300010402070502090409
Content-Type: application/octet-stream;
 name="0002-XCB-Remove-a-wrong-optimization.patch.sig"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="0002-XCB-Remove-a-wrong-optimization.patch.sig"

iQEcBAABCAAGBQJNC8HvAAoJECLkKOvLj8sGlskH/jMYNCbFm3mSzLRNFUywicRozMxo2KaW
E3nU7dy7+5zoMF/cgvLxVMlroZTJsTfwzsMk48AXxlOW3ad057uksaPa8Jpmo4WPb9ZKfRZM
rRrlVKYXI7xpSOf9+bpJaWSCPHW8xSzJfJoS4b9Ej1quw5b/r/QmTt0BeBGRoQ754FvBM4gW
uWqU3Ht0CC0RUe3gImnVW6AxFx36fM7M0j/SGuE2lJ3qgmHdqOYje3o0H21YogJ+jUgJ4chs
7uLtxeVSpzA+aotW679JjdbKwrEQQF3jTe2Fi96yRVDX1L75a8y1G2UhG86dCejFrwuI7dmV
tw6NizueB83Em3SPbLXI/qE=
--------------070300010402070502090409--


More information about the cairo mailing list