[cairo] 答复: Is it an error in cairo-surface.c

[oken]

sorror, I made a mistake!





发件人：oken
发送日期：2010-09-30 14:57
收件人：cairo at cairographics.org 
抄送：
主题：[cairo] Is it an error in cairo-surface.c 

VERISON:cairo 1.11.1

cairo_status_t
_cairo_surface_fill_rectangles (cairo_surface_t  *surface,
    cairo_operator_t         op,
    const cairo_color_t *color,
    cairo_rectangle_int_t *rects,
    int    num_rects)
{
    cairo_int_status_t status;
    if (surface->status)
 return surface->status;
    assert (! surface->is_snapshot);
    if (surface->finished)
 return _cairo_surface_set_error (surface,CAIRO_STATUS_SURFACE_FINISHED);
    if (num_rects == 0)
 return CAIRO_STATUS_SUCCESS;
    if (surface->backend->fill_rectangles) {
 status = surface->backend->fill_rectangles (surface, op, color,
          rects, num_rects);
 if (status != CAIRO_INT_STATUS_UNSUPPORTED)
     return _cairo_surface_set_error (surface, status);
    }
    return _cairo_surface_set_error (surface,
     _cairo_surface_fallback_fill_rectangles (surface, op, color,
           rects, num_rects));
}

In my opinion,
 if (status != CAIRO_INT_STATUS_UNSUPPORTED)
     return _cairo_surface_set_error (surface, status);
should be 
 if (status && status != CAIRO_INT_STATUS_UNSUPPORTED)
     return _cairo_surface_set_error (surface, status);
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cairographics.org/archives/cairo/attachments/20100930/e4b14036/attachment.htm>