[cairo] [PATCH] gl: fix bug in _cairo_gl_surface_embedded_operand_init()
chris at chris-wilson.co.uk
Fri Dec 9 01:25:36 PST 2011
On Fri, 9 Dec 2011 16:13:59 +0800, Chuanbo Weng <strgnm at gmail.com> wrote:
> The operand->texture.surface should be set to right value, not
> NULL. Otherwise, when doing _cairo_gl_surface_operand_init(),
> the texture.surface in operand struct will also be NULL, which
> is incorrect. This fix regression suite in 43 test cases(such
> as source-clip) in cairo/test/.
Hah, so the reason I removed the link to itself from the embedded
operand was that I thought I was avoiding a reference cycle. However,
the operands were leaking the surfaces they created anyway...
Chris Wilson, Intel Open Source Technology Centre
More information about the cairo