[cairo] [PATCH] gl: Fix offset for non-texture surface patterns

[Andrea Canciani]

On Thu, Nov 10, 2011 at 9:45 PM, Martin Robinson <mrobinson at igalia.com> wrote:
> On Sat, Nov 5, 2011 at 2:12 AM, Andrea Canciani <ranma42 at gmail.com> wrote:
>> I'm not sure if the approach is correct, but, assuming it is, how about simply
>> using _cairo_surface_paint()?
>> Using a constant (0,0) offset looks weird to me.
>
> I think _cairo_surface_paint eventually calls this function again
> leading to infinite recursion. It seems we need to use a lower level
> API here.

_cairo_surface_offset_paint() simply transforms the clip and calls
_cairo_surface_paint()

I'm not sure if the infinite loop you are describing is actually
possible (maybe by using a surface as source to draw on that same
surface...).
Anyway if that's an issue with _cairo_surface_paint(), that will also
be a problem with _cairo_surface_offset_paint().

Andrea

>
> --Martin
>