[cairo] Crash in cairo_surface_get_mime_data()
psychon at znc.in
Tue Oct 4 12:02:03 PDT 2011
On 04.10.2011 18:33, Andrea Canciani wrote:
> On Tue, Oct 4, 2011 at 6:11 AM, Uli Schlachter <psychon at znc.in> wrote:
>> On 04.10.2011 11:56, Chris Wilson wrote:
>>> On Mon, 03 Oct 2011 23:09:42 +0200, Uli Schlachter <psychon at znc.in> wrote:
>>>> Then I also wonder how this should be added to the test suite. The only thing
>>>> that currently calls cairo_surface_get_mime_data() is api-special-cases, but
>>>> this problem doesn't really fit into that test. Should this get its own test
>>>> case, looking something like the code below?
>>> Sure, start a suite of tests for mime-surface-api.c As we also want to make
>>> sure that we do get the exact same data returned from get as for set.
>>> (The drawing test should cover that, but doesn't actually imply no copy
>>> was made etc.)
>> Attached are two patches. First one adds a new test case and the other is the
>> one-line fix I posted earlier.
>> If no one complains, I'll eventually push this.
> Should we add a "replace" in the test case?
> IIRC it should not matter, because create-replace-destroy should be
> the same as create-(destroy-create)-destroy, but... who knows when we
> will forget about it and break it in an unnoticed way
Good idea, new patches attached.
Q: Because it reverses the logical flow of conversation.
A: Why is putting a reply at the top of the message frowned upon?
More information about the cairo