[cairo] [PATCH] gl: fix the same surface bug and cairo_glx_surface_t source surface bug

[Chuanbo Weng]

The drawing error is an issue in the output. The "self-copy" and
"subsurface"
I mentioned are the cases in cairo/test/: self-copy.c and subsurface.c.
So you can check the output pictures, which are incorrect.
These cases use target surface as their source surface at the same time,
which
cause the render output incorrect. (When you bind one image from a texture
to an
FBO,  and If you do try to read and write to the same image, you get
undefined
results.)

2012/1/11 Chris Wilson <chris at chris-wilson.co.uk>

> On Wed, 11 Jan 2012 17:03:46 +0800, Chuanbo Weng <strgnm at gmail.com> wrote:
> > We have to create a new surface to avoid drawing error when the source
> > and destination is the same surface. Also, we should create a new texture
> > surface when the source surface type is cairo_glx_surface_t. This fix
> > issue in self-copy, subsurface and subsurface-modify-child test case.
>
> What's the drawing error? A GL error? An issue in the output? Due to its
> render roots, self-copy is undefined in the Cairo API so unless this
> prevents an explicit error against the GL spec, I'm not going to accept
> it without the larger issue (of defining self-copy) being addressed.
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.cairographics.org/archives/cairo/attachments/20120111/5e64a49c/attachment.html>