[cairo] [PATCH] gl: return unsupported if the source surface type is gl-window in upload_boxes()

Chris Wilson chris at chris-wilson.co.uk
Thu Jul 12 10:20:56 PDT 2012

On Thu, 12 Jul 2012 16:44:19 +0800, Chuanbo Weng <strgnm at gmail.com> wrote:
> When the source surface type is gl-window in upload_boxes(), return
> unsupported. Together with the patch I sent just now, fixes 8 fails
> in cairo-test-suite.

Try to avoid adding single purpose functions to the general surface
layer. At that level, we should only have functions that apply to all
types of raster and paginated surfaces.

It looks like we could achieve the desired effect with the check pushed
down into _cairo_gl_spans_compositor::copy_boxes(). So I pushed a
different patch, can you please look it over.

Thanks for the couple of patches,

Chris Wilson, Intel Open Source Technology Centre

More information about the cairo mailing list