[cairo] [PATCH] image: Add public API for the creation of a surface for a pixman_image_t

[Søren Sandmann]

Chris Wilson <chris at chris-wilson.co.uk> writes:

>> If the main reason for this API is to help people with weird hardware,
>> maybe cairo_format_t could simply be extended to cover all known pixman
>> formats?
>
> The goal was to try and advertise only a few formats that are well
> supported and well tested, mainly to prevent the reduce the complexity
> of implementation. However, all that really means is that instead of
> checking for CAIRO_FORMAT_INVALID and performing a conversion to a known
> format, the backend checks against a list of formats it can handle.
> So the primary point has to be, do we want people to feed
> all-and-sundry formats into cairo? The goal there has always been to
> guide people to choose formats that will work well anywhere.

If only a few of the pixman formats will be supported, then I guess I
don't understand the usecase that this new API is supposed to help with.

Also, as an aside, pixman has had pixman_image_get_format() for a while,
so there is no need to pass it in separately.


Soren