[cairo] [cairo-commit] src/cairo-gl-composite.c src/cairo-gl-device.c src/cairo-gl-dispatch-private.h src/cairo-gl-msaa-compositor.c src/cairo-gl-operand.c src/cairo-gl-private.h src/cairo-gl-surface.c

[Chris Wilson]

On Thu, 17 May 2012 12:14:20 -0700, Martin Robinson <mrobinson at igalia.com> wrote:
> As for the last conditional, use of the MSAA compositor
> is currently guarded by the CAIRO_GL_COMPOOSITOR environment
> variable set to "msaa." Without that present, the MSAA compositor 
> isn't instantiated at all, so this check isn't run.

In the long run, I'd rather migrate away from setting that env var (and
now I regret not putting _DEBUG_ into its name to stress that it is a
short term solution and primarily a tool for debugging alternative
compositors).

I'm definitely not comfortable with making MSAA the default as we want
consistent high quality output across the broad range of devices
(including all those low-resolution devices on the desktop) that
cairo-gl is expected to run on. So some runtime flag for how to handle
DEFAULT is going to be required, I think.  For convenience you can
simply set it to true whilst developing the msaa compositor. But
introducing that flag at the start reminds us to consider the
implications.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre