[cairo] [PATCH] gl: use _cairo_gl_operand_copy to fix unblanced reference count

Chris Wilson chris at chris-wilson.co.uk
Wed May 30 02:47:59 PDT 2012

On Wed, 30 May 2012 15:13:46 +0800, Yuanhan Liu <yuanhan.liu at linux.intel.com> wrote:
> Use _cairo_gl_operand_copy to do the operand copy instead of by
> something like *operand = surface->operand.
> This would fix a crash introduced by operator-source test case, which
> forgot to do reference while copying operand but did dereference while
> destroying surface at combine_clip_as_traps().
> Signed-off-by: Yuanhan Liu <yuanhan.liu at linux.intel.com>

I think for the case where we create and own the texture, the extra
reference is superfluous, so I dropped it from this patch.

Pushed, thanks,

Chris Wilson, Intel Open Source Technology Centre

More information about the cairo mailing list