[cairo] [PATCH 1/2] xlib: Don't crash when swapping a 0-sized glyph

[Adam Jackson]

On Fri, 2012-11-16 at 19:59 +0100, Uli Schlachter wrote:

> I haven't forgotten this patch. However, I have no clue what the original
> "server crashes on 0x0 glyphs" bug is about nor if we want to keep the
> work-around for that. My hope is that the almighty Chris could help us here.

The original server bug was this, I believe:

http://cgit.freedesktop.org/xorg/xserver/commit/render/render.c?id=622fc98fd08aba98369e6933c3ab8c9ff85385d5

~/xserver% git describe --contains 622fc98fd08aba98369e6933c3ab8c9ff85385d5 
xorg-server-1.7.99.1~63

_cairo_xlib_traps_compositor_get() gets called if the render version is
>= 0.4; given that 0.5 was when ARGB cursors were added, that's
somewhere back in the XFree86 era.  So presumably this path is indeed
broken for sufficiently old xserver.  Naughty, introducing a regression
like that.

I can come up with a testcase I suppose, but it will likely be sometime
after the upcoming holiday as I'll be travelling a bit.

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.cairographics.org/archives/cairo/attachments/20121116/df274fc8/attachment.pgp>