[cairo] Question regarding cairo-trace for map-to-image and unmap-image

[Dongyeon Kim]

Thanks for the quick fix.

However, after applying the patch I now get assert fails in cairo_surface_destroy.

[  0]      egl   cairo_gl_map_to_image.3249 cairo-perf-trace: cairo-surface.c:957: cairo_surface_destroy: Assertion `((*&(&surface->ref_count)->ref_count) > 0)' failed.

The unmapped image surface gets destroyed automatically in cairo_surface_unmap_image, but the script puts the surface in the dictionary, and mistakenly calls cairo_surface_destroy again.

Dongyeon Kim

------- Original Message -------
Sender : Chris Wilson<chris at chris-wilson.co.uk>
Date : 2012-11-27 21:29 (GMT+09:00)
Title : Re: [cairo] Question regarding cairo-trace for map-to-image and unmap-image

On Tue, 27 Nov 2012 11:42:53 +0000 (GMT), Dongyeon Kim wrote:
> Hello,
> 
> I have a working cairo sample that uses map-to-image to map gl surface to image surface, and unmaps afterwards.
> I have created a trace file for the sample using cairo-trace, but when I try to run the trace file using cairo-perf-trace, I get the following error.
> 
> [  0]      egl   cairo_gl_map_to_image.5695 Error during replay, line 30: invalid value (typically too big) for the size of the input (surface, pattern, etc.)
> [ # ]    image: pixman 0.26.0
> [  0]    image   cairo_gl_map_to_image.5695 Error during replay, line 30: invalid value (typically too big) for the size of the input (surface, pattern, etc.)
> [ # ]  image16: pixman 0.26.0
> [  0]  image16   cairo_gl_map_to_image.5695 Error during replay, line 30: invalid value (typically too big) for the size of the input (surface, pattern, etc.)
> 
> It seems that when trying to run unmap-image from script it is not getting the right parameters.

Whoops, the operand emission for map-to-image and unmap-image was plain
broken. Please try again with:

commit 376d39121c0d4eba8f0a22be71f782ce18e50923
Author: Chris Wilson 
Date:   Tue Nov 27 12:25:56 2012 +0000

    trace: Fix operand emission for map-to-image and unmap-image
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre