[cairo] 1.12.2 -> 1.12.4 upgrade breakage

[Thomas Klausner]

Hi!

I've tried updating the cairo package in pkgsrc from 1.12.2 to 1.12.4,
but had to revert it, since this broke on at least OS X Lion (tested
by tron, cc'd) and NetBSD-6.99.12/amd64 (tested by myself).

The failure mode of the release tarball was (on OS X, for xchat):
# xchat
The program 'xchat' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadAccess (attempt to access private resource denied)'.
  (Details: serial 5738 error_code 10 request_code 133 minor_code 1)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the --sync command line
   option to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)

Adding this patch
http://cgit.freedesktop.org/cairo/commit/?id=b1532f465e05d566f6d160c5ca916a5a12614067
fixed some occurrences of the problem for xchat, but not all of them
(wireshark works, gimp doesn't). Ask tron for details.

On NetBSD, the failure when starting firefox was:
# firefox
###!!! ABORT: X_ShmAttach: BadAccess (attempt to access private resource denied); 11 requests ago: file /scratch/devel/xulrunner/work/mozilla-release/toolkit/xre/nsX11ErrorHandler.cpp, line 157
###!!! ABORT: X_ShmAttach: BadAccess (attempt to access private resource denied); 11 requests ago: file /scratch/devel/xulrunner/work/mozilla-release/toolkit/xre/nsX11ErrorHandler.cpp, line 157
zsh: segmentation fault (core dumped) firefox

The xserver coming with NetBSD is based on xorg-server-1.10.3. pixman
is at 0.26.2 (latest stable AFAIK), the x.org support libraries used
by cairo are pretty much latest (ask for details).

Please let me know if there are further patches I can test or further
details you need.

Thanks,
 Thomas