[cairo] Firefox failure with cairo 1.12.6 on NetBSD-current amd64

[Uli Schlachter]

Hi,

On 25.10.2012 10:59, Chris Wilson wrote:
> On Wed, 24 Oct 2012 15:39:44 +0200, Martin Husemann <martin at duskware.de> wrote:
>> pkgsrc recently updated cairo to version 1.12.6 and that causes my firefox
>> to crash at startup with:
>>
>> ###!!! ABORT: X_SendEvent: BadValue (integer parameter out of range for operation); 494 requests ago: file /usr/pkgobj/devel/xulrunner/work/mozilla-release/toolkit/xre/nsX11ErrorHandler.cpp, line 157
> 
> This is the error that Soren predicted - BadVale of 205 corresponds to
> the ShmCompletionEvent of 77 | 0x80.
> 
> Can you please take a look at src/cairo-xlib-surface-shm.c,
> xorg_has_buggy_send_shm_completion_event() and add a necessary clause to
> detect your XServer? Or attach your xdpyifo?

Chris, what do you think about the following alternative:

Instead of guessing, we should test the X11 server. When the
cairo_xlib_display_t is created, cairo once sends a SHMCompletion event to
itself and checks if it works (similar to how XShmAttach is already tested,
possibly even in the same function, can_use_shm()).

I feel bad for not attaching a patch to this mail, but I don't have the time
right now. So if anyone thinks that this might be a good idea and would like to
implement it, feel free.

Cheers,
Uli
-- 
"Why make things difficult, when it is possible to make them cryptic
and totally illogical, with just a little bit more effort?" -- A. P. J.