[cairo] FW: [patch] gl: disable GL_DITHER

Bill Spitzak spitzak at gmail.com
Fri Feb 15 12:22:30 PST 2013


Doesn't it make smooth gradients not have banding?

Maybe turn it only only when rendering a gradient.

Chris Wilson wrote:
> On Thu, Feb 14, 2013 at 07:22:45PM +0000, Henry (Yu) Song - SISA wrote:
>> re-post patch
>> ________________________________________
>> From: Henry (Yu) Song - SISA
>> Sent: Tuesday, January 29, 2013 9:30 AM
>> To: cairo at cairographics.org
>> Subject: [patch] gl: disable GL_DITHER
>>
>> gl: disable GL_DITHER
>>
>> Leaving GL_DITHER enabled (by default) causes color pixel mismatch on 
>> some drivers by comparing uploading then glReadPixels and original image
> 
> I've pushed it. I had a moment of doubt, thinking that maybe we should
> respect GL_DITHER when rendering to the destination, and turn off
> differing around Draw/ReadPixels.
> 
> Getting that right is easier once someone has a use case for GL_DITHER.
> -Chris
> 


More information about the cairo mailing list