[cairo] [PATCH]: gl: Return surface in error when creating oversized texture surfaces

Martin Robinson mrobinson at igalia.com
Mon Jul 29 14:14:26 PDT 2013


On 07/29/2013 02:10 PM, Chris Wilson wrote:
> On Mon, Jul 29, 2013 at 02:02:34PM -0700, Martin Robinson wrote:
>> If you are more comfortable with it, I can simply replicate the check at
>> the beginning of _cairo_gl_surface_create_similar and the associated
>> error surface. I think that's sufficient for what we need in WebKit.
> 
> I think returning the error surface is indeed the better approach, as it
> prevents surprises. It is just that it is at odds with the ethos that
> Cairo can (and should) handle infinite surfaces and coordinate systems
> that chaffs. Reality is such a let down.

Agreed! Though I have been considering whether or not tiled surfaces
make sense, considering that some images on the web go past 5000 pixels
wide. Consider the fish sprite image in the IE fishbowl example:

http://ie.microsoft.com/testdrive/performance/fishbowl/

--Martin



More information about the cairo mailing list