[cairo] Possible bug in commit c7ce1b68

Adrian Johnson ajohnson at redneon.com
Tue Mar 26 14:40:44 PDT 2013


On 27/03/13 00:12, Guillaume Ayoub wrote:
> In the _cairo_pdf_surface_add_padded_image_surface() function introduced
> in this commit:
> http://cgit.freedesktop.org/cairo/commit/?id=c7ce1b68d5370f6e804a6edbf5be4bca3a5b7c57
> 
> This code looks like it has a typo:
> 
> if (_cairo_fixed_integer_ceil(box.p1.x) < 0 ||
> _cairo_fixed_integer_ceil(box.p1.y) < 0 ||
> _cairo_fixed_integer_floor(box.p2.y) > w ||
> _cairo_fixed_integer_floor(box.p2.y) > h)
> 
> The first box.p2.y value should probably be box.p2.x.
> 
> I have no idea what the implications of this bug are, or how to
> test/reproduce it.
> 

Fixed. Thanks for the bug report.





More information about the cairo mailing list