[cairo] [PATCH] Fix width and height args for _cairo_xcb_connection_copy_area()

[Uli Schlachter]

On 20.08.2014 09:35, Uli Schlachter wrote:
> On 19.08.2014 23:59, Maks Naumov wrote:
>> Signed-off-by: Maks Naumov <maksqwe1 at ukr.net>
>> ---
>>  src/cairo-xcb-surface-core.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/cairo-xcb-surface-core.c b/src/cairo-xcb-surface-core.c
>> index 545fd28..9c0c0a0 100644
>> --- a/src/cairo-xcb-surface-core.c
>> +++ b/src/cairo-xcb-surface-core.c
>> @@ -573,7 +573,7 @@ _cairo_xcb_surface_core_copy_boxes (cairo_xcb_surface_t		*dst,
>>  						 src->x0 + x1,
>>  						 src->y0 + y1,
>>  						 x1, y1,
>> -						 x2 - x2, y2 - x2);
>> +						 x2 - x1, y2 - y1);
>>  	    }
>>  	}
>>      }
>>
> 
> Ouch. How did you find this? Any particular test case that catches this?
> 
> I will run this through the test suite later, for now I am just curious about
> what you did to find this and why no one else did.

Test suite results don't change due to this patch. Even an ASSERT_NOT_REACHED
changes anything, so this code isn't reached by the test suite.

Bummer.

Uli
-- 
Homophobia - The fear that another man will treat you the way you treat women.