[cairo] [PATCH] Minor fixes in the new downscaling code.
Bryce W. Harrington
b.harrington at samsung.com
Fri Feb 7 22:45:16 CET 2014
On Wed, Feb 05, 2014 at 01:32:02AM +0100, Krzysztof Kosiński wrote:
> 2014-02-04 Uli Schlachter <psychon at znc.in>:
> > Does anyone know why the test suite didn't catch this?
> > I don't have the time to look closely at this right now, but I would expect that
> > we either have some wrong reference images and tests now start to fail or that
> > the scaling tests don't cover enough cases...
I would expect the same...
> The test suite actually contains only one test for downscaling and
> it's not testing the different filters.
The test includes test cases for fast, good, best, nearest, and bilinear
filters, each at three different levels of resolution. The intention is
that it should test all of the different filters, so if it isn't please
indicate what it's missed. (And ideally, include updates to the test
with your patch so we can improve its coverage).
More information about the cairo