[cairo] [PATCH] image: Add NULL checks for return value of _pixman_image_for_color()

Bryce W. Harrington b.harrington at samsung.com
Mon Mar 3 17:25:38 PST 2014


On Wed, May 15, 2013 at 06:42:12PM +0900, 江頭幸路 wrote:
> Hi maintainers,
> 
> Could you have a look at the patch I attached to the first mail?
> It's a patch to cairo-image-compositor.c.
> The source file has such null checks at other lines but not at patched
> lines.
> 
> If the patch has any problems, I would appreciate it if you let me know.

Hi Koji

The patch looked sensible to me.  It just checks the return from
_pixman_image_for_color() for null values, for non-optimized builds.
Thanks for your contribution.

I've updated the patch to apply to the current tree and pushed it.

Bryce

> Koji
> 
> 2013/4/29 江頭幸路 <koji.egashira at access-company.com>
> 
> > Hi,
> >
> > > ________________________________________
> > > The contents of this e-mail message and any attachments are confidential
> > and are intended solely for the addressee. The information may also be
> > legally privileged.
> > > This transmission is sent in trust, and the sole purpose of delivery to
> > the intended recipient. If you have received this transmission in error,
> > any use, reproduction or dissemination of this transmission is strictly
> > prohibited.
> > > If you are not the intended recipient, please immediately notify the
> > sender by reply e-mailer and delete this message and its attachments, if
> > any.
> > > Thank you for your cooperation.
> > > ________________________________________
> >
> > Please ignore this message in the e-mail from my address.
> > It is appended automatically by mail server when sent, so I cannot remove
> > it.
> >
> >
> > Sincerely,
> > Koji Egashira
> >
> >
> >
> > 2013/4/29 江頭幸路 <koji.egashira at access-company.com>
> >
> >> This patch fixes crash in pixman_image_composite32().
> >>
> >>
> >
> 
> -- 
> .
> 
> ________________________________________
> The contents of this e-mail message and any attachments are confidential and are intended solely for the addressee. The information may also be legally privileged. 
> This transmission is sent in trust, and the sole purpose of delivery to the intended recipient. If you have received this transmission in error, any use, reproduction or dissemination of this transmission is strictly prohibited. 
> If you are not the intended recipient, please immediately notify the sender by reply e-mailer and delete this message and its attachments, if any.
> Thank you for your cooperation.
> ________________________________________

> -- 
> cairo mailing list
> cairo at cairographics.org
> http://lists.cairographics.org/mailman/listinfo/cairo


More information about the cairo mailing list