[cairo] [PATCH 0/7] Bunch of distcheck fixes

Bryce W. Harrington b.harrington at samsung.com
Tue Mar 18 18:06:20 PDT 2014


On Fri, Mar 14, 2014 at 05:57:49PM +0000, Bryce W. Harrington wrote:
> On Fri, Mar 14, 2014 at 04:00:52PM +0100, Uli Schlachter wrote:
> > PASS -> FAIL # device-offset-scale.image.argb32
> > PASS -> FAIL # large-source-roi.image.argb32
> > PASS -> FAIL # surface-pattern-big-scale-down.image.argb32
> > PASS -> FAIL # surface-pattern-scale-down-extend-none.image.argb32
> > PASS -> FAIL # surface-pattern-scale-down-extend-pad.image.argb32
> > PASS -> FAIL # surface-pattern-scale-down-extend-reflect.image.argb32
> > PASS -> FAIL # surface-pattern-scale-down-extend-repeat.image.argb32
> > PASS -> FAIL # surface-pattern-scale-down.image.argb32
> > Bisects to fb57ea13e04d82866cbc8e86c83261148bb3e231, definitely a regression for
> > large-source-roi, the others might need new ref images
> 
> I plan to re-run the suite with KK's new patch applied this evening.
> 
> > >> As mentioned below, there is still some minor cruft in distcheck, but
> > >> nothing IMHO that is worth holding up the release for.  However, tests
> > >> are in a poor shape right now.
> > >>
> > >> I ran 'make check' comparisons between the 1.12.8 release (as tagged in
> > >> git), and master HEAD from earlier today:
> > >>
> > >>                    1.12.8      HEAD
> > >>  ----------------------------------------------------------------------
> > >>  Tests run:        22751       24838
> > >>  Passed:           15809       15881
> > >>  Failed:           4198        5385 
> > >>  Expected Failed:  405         330      
> > >>  Error:            1           1        
> > >>  Crashed:          227         1018 
> > >>  Untested:         2111        2223 
> > >>  Total:            22751       24838

New results:

#######             HEAD	Downsc.      Crash-Fixes
# Tests run:        24838	24838	     24838
# Passed:           15884	15433	     16725
# Failed:           5383	5173 	     5528 
# Expected Failed:  330		330	     332	 
# Error:            1		1	     1	 
# Crashed:          1017	1678 	     29	 
# Untested:         2223	2223 	     2223 
# Total:            24838	24838	     24838
#######

The HEAD column is current git, which should be basically the same as
the previous HEAD; delta in results is likely due to a handful of tests
which randomly crash/fail.

Downsc. is HEAD plus KK's two patches.  Unfortunately these appear to be
causing a bunch of tests to crash now.  Probably should get that cleaned
up before pulling these patches.

Crash-Fixes is HEAD plus Uli's two test fixup patches.  I'm actually
seeing this clean up a lot more test crashes than Uli had measured
(perhaps just due to differences in what we're enabling in our
configs).

Bryce



More information about the cairo mailing list