[cairo] [PATCH 0/2] Update pixman reference images

[Bryce Harrington]

On Thu, Oct 09, 2014 at 06:38:10PM -0700, Bryce Harrington wrote:
> The downscaling tests check all the different filter levels, to three
> different scales.  Two of the scales, 96:96 and 96:24, are easy scaling
> settings and thus should produce essentially identical results.  The
> third scaling, 96:95, requires blurring the lines bordering solid
> colors, and we generally are fairly permissive as to what the renderer
> decides to do.  Unfortunately the various backends seem to vary quite a
> bit in what they choose to do.
> 
> Because of this, I'm tempted to just drop the 96:95 scale test since it
> will always be finicky.  However, I do think it's important that we test
> "off" scales like this.

Before I commit this I'd like a second opinion about dropping the test
vs. just updating the refs with this patchset.

> But meantime, here are updates of the reference images, along with a
> update-refs.sh script I used to copy the refs from the test output.
> This works to avoid adding redundant reference images by testing them
> before copying them.  This script may be worth extending if we have
> other tests that need their reference images updated to match test
> output.

This should result in about +100 passing tests.

#######             Current     Patched
# Tests run:        645		645
# Passed:           267		373
# Failed:           153		47 
# Expected Failed:  0		0  
# Error:            0		0  
# Crashed:          0		0  
# Untested:         225		225
# Total:            645		645
#######

Fwiw, the BEST tests at 96:24 scaling are rendering with heavy
artifacting, compared with other filters at this scale.  I've not had a
chance to investigate it though.

Bryce

> Bryce Harrington (2):
>   test: Add an update-refs.sh script to update reference images
>   test: Update pixman downscaling 95 reference images
> 
>  .../pixman-downscale-best-95.image.rgb24.ref.png   |  Bin 0 -> 659 bytes
>  .../pixman-downscale-best-95.image16.rgb24.ref.png |  Bin 0 -> 648 bytes
>  .../reference/pixman-downscale-best-95.pdf.ref.png |  Bin 0 -> 479 bytes
>  .../reference/pixman-downscale-best-95.ps2.ref.png |  Bin 0 -> 460 bytes
>  .../reference/pixman-downscale-best-95.ps3.ref.png |  Bin 0 -> 460 bytes
>  ...ixman-downscale-best-95.recording.rgb24.ref.png |  Bin 0 -> 659 bytes
>  test/reference/pixman-downscale-best-95.ref.png    |  Bin 685 -> 771 bytes
>  .../pixman-downscale-best-95.script.ref.png        |  Bin 0 -> 772 bytes
>  .../pixman-downscale-best-95.svg11.ref.png         |  Bin 0 -> 474 bytes
>  .../pixman-downscale-best-95.svg12.ref.png         |  Bin 0 -> 474 bytes
>  ...ixman-downscale-best-95.test-base.rgb24.ref.png |  Bin 0 -> 659 bytes
>  ...n-downscale-best-95.test-fallback.rgb24.ref.png |  Bin 0 -> 659 bytes
>  ...ixman-downscale-best-95.test-mask.rgb24.ref.png |  Bin 0 -> 659 bytes
>  ...-downscale-best-95.test-paginated.rgb24.ref.png |  Bin 0 -> 659 bytes
>  ...xman-downscale-best-95.test-spans.rgb24.ref.png |  Bin 0 -> 659 bytes
>  ...xman-downscale-best-95.test-traps.rgb24.ref.png |  Bin 0 -> 659 bytes
>  ...an-downscale-best-95.xcb-fallback.rgb24.ref.png |  Bin 0 -> 659 bytes
>  ...-downscale-best-95.xcb-render-0_0.rgb24.ref.png |  Bin 0 -> 659 bytes
>  ...man-downscale-best-95.xcb-window&.rgb24.ref.png |  Bin 0 -> 474 bytes
>  ...xman-downscale-best-95.xcb-window.rgb24.ref.png |  Bin 0 -> 474 bytes
>  .../reference/pixman-downscale-best-95.xcb.ref.png |  Bin 0 -> 474 bytes
>  ...n-downscale-best-95.xlib-fallback.rgb24.ref.png |  Bin 0 -> 659 bytes
>  ...downscale-best-95.xlib-render-0_0.rgb24.ref.png |  Bin 0 -> 659 bytes
>  ...man-downscale-best-95.xlib-window.rgb24.ref.png |  Bin 0 -> 474 bytes
>  .../pixman-downscale-best-95.xlib.ref.png          |  Bin 0 -> 474 bytes
>  ...man-downscale-bilinear-95.image16.rgb24.ref.png |  Bin 0 -> 481 bytes
>  .../pixman-downscale-bilinear-95.pdf.ref.png       |  Bin 0 -> 479 bytes
>  .../pixman-downscale-bilinear-95.ps2.ref.png       |  Bin 0 -> 460 bytes
>  .../pixman-downscale-bilinear-95.ps3.ref.png       |  Bin 0 -> 460 bytes
>  .../reference/pixman-downscale-bilinear-95.ref.png |  Bin 685 -> 474 bytes
>  .../pixman-downscale-bilinear-95.script.ref.png    |  Bin 0 -> 481 bytes
>  .../pixman-downscale-fast-95.image16.rgb24.ref.png |  Bin 0 -> 304 bytes
>  .../reference/pixman-downscale-fast-95.pdf.ref.png |  Bin 0 -> 479 bytes
>  .../reference/pixman-downscale-fast-95.ps2.ref.png |  Bin 0 -> 299 bytes
>  .../reference/pixman-downscale-fast-95.ps3.ref.png |  Bin 0 -> 299 bytes
>  .../pixman-downscale-fast-95.svg11.ref.png         |  Bin 0 -> 474 bytes
>  .../pixman-downscale-fast-95.svg12.ref.png         |  Bin 0 -> 474 bytes
>  .../pixman-downscale-good-95.image16.rgb24.ref.png |  Bin 0 -> 481 bytes
>  .../reference/pixman-downscale-good-95.pdf.ref.png |  Bin 0 -> 479 bytes
>  .../reference/pixman-downscale-good-95.ps2.ref.png |  Bin 0 -> 460 bytes
>  .../reference/pixman-downscale-good-95.ps3.ref.png |  Bin 0 -> 460 bytes
>  test/reference/pixman-downscale-good-95.ref.png    |  Bin 685 -> 474 bytes
>  .../pixman-downscale-good-95.script.ref.png        |  Bin 0 -> 481 bytes
>  ...xman-downscale-nearest-95.image16.rgb24.ref.png |  Bin 0 -> 304 bytes
>  .../pixman-downscale-nearest-95.pdf.ref.png        |  Bin 0 -> 479 bytes
>  .../pixman-downscale-nearest-95.ps2.ref.png        |  Bin 0 -> 299 bytes
>  .../pixman-downscale-nearest-95.ps3.ref.png        |  Bin 0 -> 299 bytes
>  .../pixman-downscale-nearest-95.svg11.ref.png      |  Bin 0 -> 474 bytes
>  .../pixman-downscale-nearest-95.svg12.ref.png      |  Bin 0 -> 474 bytes
>  test/update-refs.sh                                |   84 ++++++++++++++++++++
>  50 files changed, 84 insertions(+)
>  create mode 100644 test/reference/pixman-downscale-best-95.image.rgb24.ref.png
>  create mode 100644 test/reference/pixman-downscale-best-95.image16.rgb24.ref.png
>  create mode 100644 test/reference/pixman-downscale-best-95.pdf.ref.png
>  create mode 100644 test/reference/pixman-downscale-best-95.ps2.ref.png
>  create mode 100644 test/reference/pixman-downscale-best-95.ps3.ref.png
>  create mode 100644 test/reference/pixman-downscale-best-95.recording.rgb24.ref.png
>  create mode 100644 test/reference/pixman-downscale-best-95.script.ref.png
>  create mode 100644 test/reference/pixman-downscale-best-95.svg11.ref.png
>  create mode 100644 test/reference/pixman-downscale-best-95.svg12.ref.png
>  create mode 100644 test/reference/pixman-downscale-best-95.test-base.rgb24.ref.png
>  create mode 100644 test/reference/pixman-downscale-best-95.test-fallback.rgb24.ref.png
>  create mode 100644 test/reference/pixman-downscale-best-95.test-mask.rgb24.ref.png
>  create mode 100644 test/reference/pixman-downscale-best-95.test-paginated.rgb24.ref.png
>  create mode 100644 test/reference/pixman-downscale-best-95.test-spans.rgb24.ref.png
>  create mode 100644 test/reference/pixman-downscale-best-95.test-traps.rgb24.ref.png
>  create mode 100644 test/reference/pixman-downscale-best-95.xcb-fallback.rgb24.ref.png
>  create mode 100644 test/reference/pixman-downscale-best-95.xcb-render-0_0.rgb24.ref.png
>  create mode 100644 test/reference/pixman-downscale-best-95.xcb-window&.rgb24.ref.png
>  create mode 100644 test/reference/pixman-downscale-best-95.xcb-window.rgb24.ref.png
>  create mode 100644 test/reference/pixman-downscale-best-95.xcb.ref.png
>  create mode 100644 test/reference/pixman-downscale-best-95.xlib-fallback.rgb24.ref.png
>  create mode 100644 test/reference/pixman-downscale-best-95.xlib-render-0_0.rgb24.ref.png
>  create mode 100644 test/reference/pixman-downscale-best-95.xlib-window.rgb24.ref.png
>  create mode 100644 test/reference/pixman-downscale-best-95.xlib.ref.png
>  create mode 100644 test/reference/pixman-downscale-bilinear-95.image16.rgb24.ref.png
>  create mode 100644 test/reference/pixman-downscale-bilinear-95.pdf.ref.png
>  create mode 100644 test/reference/pixman-downscale-bilinear-95.ps2.ref.png
>  create mode 100644 test/reference/pixman-downscale-bilinear-95.ps3.ref.png
>  create mode 100644 test/reference/pixman-downscale-bilinear-95.script.ref.png
>  create mode 100644 test/reference/pixman-downscale-fast-95.image16.rgb24.ref.png
>  create mode 100644 test/reference/pixman-downscale-fast-95.pdf.ref.png
>  create mode 100644 test/reference/pixman-downscale-fast-95.ps2.ref.png
>  create mode 100644 test/reference/pixman-downscale-fast-95.ps3.ref.png
>  create mode 100644 test/reference/pixman-downscale-fast-95.svg11.ref.png
>  create mode 100644 test/reference/pixman-downscale-fast-95.svg12.ref.png
>  create mode 100644 test/reference/pixman-downscale-good-95.image16.rgb24.ref.png
>  create mode 100644 test/reference/pixman-downscale-good-95.pdf.ref.png
>  create mode 100644 test/reference/pixman-downscale-good-95.ps2.ref.png
>  create mode 100644 test/reference/pixman-downscale-good-95.ps3.ref.png
>  create mode 100644 test/reference/pixman-downscale-good-95.script.ref.png
>  create mode 100644 test/reference/pixman-downscale-nearest-95.image16.rgb24.ref.png
>  create mode 100644 test/reference/pixman-downscale-nearest-95.pdf.ref.png
>  create mode 100644 test/reference/pixman-downscale-nearest-95.ps2.ref.png
>  create mode 100644 test/reference/pixman-downscale-nearest-95.ps3.ref.png
>  create mode 100644 test/reference/pixman-downscale-nearest-95.svg11.ref.png
>  create mode 100644 test/reference/pixman-downscale-nearest-95.svg12.ref.png
>  create mode 100755 test/update-refs.sh
> 
> -- 
> 1.7.9.5