[cairo] What happened to my patches to Pixman for image filtering?

Bryce Harrington bryce at osg.samsung.com
Wed Oct 29 12:39:51 PDT 2014


On Wed, Oct 29, 2014 at 12:03:02PM -0700, Bill Spitzak wrote:
> Quite some time ago I posted patches to Pixman to fix several bugs
> in the filter generator and to implement GOOD/BEST filtering. My
> first set got a response from Søren Sandmann, but I believe I
> addressed this response in my second series of patches (V5 in this
> mailing list, and Message-ID:
> 
>  <1411783570-24329-1-git-send-email-spitzak at gmail.com>
> 
> Have not heard anything since then.
> 
> I believe it would be much better to patch Pixman than my current
> support of filters in Cairo. But it is possible the authors
> disagree.

I don't have any involvement in pixman matters so my opinion probably
doesn't matter at all (thus my silence on the past emails), but just for
the sake of the record I'll say I'm also +1 for seeing this stuff moved
to Pixman.

Bryce

> Søren did state that he felt that having GOOD/BEST do anything other
> than bilinear may be a bad idea, and that callers should use the
> filter api. However I disagree, primarily because pixman can make
> numerous optimizations (such as using bilinear for some
> transformations) because it knows exactly what filter GOOD and BEST
> produce. Also it is trivial to use BILINEAR if that is what the
> caller really wants.
> 
> I also would like to support 2-pass and non-affine transforms but
> this is going to be considerable work on pixman, so I would like
> some assurances that patches will be considered so I am not wasting
> my time.
> 
> I am sending this only to the cairo list as my previous email all
> had both the cairo and pixman lists as recipients. I am worried this
> may have caused people's email filters to put it in the wrong bin
> and it was never seen.
> -- 
> cairo mailing list
> cairo at cairographics.org
> http://lists.cairographics.org/mailman/listinfo/cairo


More information about the cairo mailing list