[cairo] [PATCH 0/2] Fix cross-endian crashes
bryce at osg.samsung.com
Fri Oct 31 12:42:00 PDT 2014
On Fri, Oct 31, 2014 at 01:21:13PM -0400, Adam Jackson wrote:
> I'm sure I've sent these before but I don't have the thread handy. As I
> recall, the blocker before was constructing a test case; and no, I don't
> have an easy way to do that, because to do it you'd need to have an X
> server running other-endian from the test. Can we please just inspect the
> code and agree that the fix is correct?
Looks good to me.
c being 0 implies that either the height or stride were 0, which means
the second to last arg of the call to xcb_render_add_glyphs and final
arg of the XRenderAddGlyphs call will be zero as well in this case.
Looking at XRenderAddGlyphs's implementation this seems not to be
worrisome. Can't tell offhand what xcb is doing but trust it can handle
Reviewed-by: Bryce Harrington <b.harrington at samsung.com>
(Assuming no one objects, I'll land this Monday.)
> - ajax
> cairo mailing list
> cairo at cairographics.org
More information about the cairo