[cairo] [PATCH] xcb: Initialize font options from Xft resources
lukas at oxygene.sk
Fri Sep 12 01:42:56 PDT 2014
On Fri, Sep 12, 2014 at 9:46 AM, Lukáš Lalinský <lukas at oxygene.sk> wrote:
>>> + *options = *_cairo_xcb_screen_get_font_options (surface->screen);
>> Still requires a pair of _cairo_xcb_connection_acquire() /
>> _cairo_xcb_connection_release() somewhere. Cairo-xlib does this in
>> _cairo_xlib_screen_get_font_options(), but you put an assert into
>> _cairo_xcb_screen_get_font_options() making this the caller's responsibility.
>> Either place is fine with me to do the necessary locking.
> Thanks, I was not completely clear on how to do this before. I added
> it to _cairo_xcb_surface_get_font_options, as that seems consistent
> with the rest of the XCB code.
Ok, I changed my mind already, because I realized how often the
function is called. _cairo_xcb_screen_get_font_options inside the
cache-miss-if seems to be a better place for that.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 16974 bytes
Desc: not available
More information about the cairo