[cairo] Testsuite changes this week
Bryce Harrington
bryce at osg.samsung.com
Wed Sep 17 13:26:58 PDT 2014
On Wed, Sep 17, 2014 at 03:35:37PM +0200, Lukáš Lalinský wrote:
> I'm afraid I'm not going to help much with the tests. I had a short look
> and couldn't figure it out, but I'm going mostly offline for the next two
> weeks, so I'll not be able to spend more time on it soon. So the best
> option is to disable the functionality for now, as Uli suggested.
>
> Lukas
Alright sounds good, thanks Lukas.
Bryce
> On Tue, Sep 16, 2014 at 9:14 AM, Uli Schlachter <psychon at znc.in> wrote:
>
> > Hi & thanks for running these weekly tests,
> >
> > Am 16.09.2014 um 08:49 schrieb Bryce Harrington:
> > > git git git git git git
> > > 05/03 06/09 07/21 08/04 08/29 09/12
> > > -------------------------------------------------------------------
> > > Tests run: 24838 24813 24839 24838 24838 24838
> > > Passed: 15774 16015 16024 15889 15989 15808
> > > Failed: 6476 6226 6228 6372 6272 6451
> > > Expected Failed: 332 315 332 332 332 332
> > > Error: 1 1 0 0 0 0
> > > Crashed: 32 33 32 22 22 24
> > > Untested: 2223 2223 2223 2223 2223 2223
> > > Total: 24838 24813 24839 24838 24838 24838
> > >
> > > Here's the tests that changed results since the previous run:
> > >
> > >
> > http://www.bryceharrington.org/Cairo/changes-20140829-to-20140912-trent.txt
> > >
> > > 102 xcb and 70 xlib tests failed here, including a bunch of
> > > *twin-antialias-* tests. Anyone have ideas on these?
> >
> > There weren't many changes to cairo-xcb and git bisect confirms:
> >
> > e691d242d592a8556e25659fb091a2031abee4c9 is the first bad commit
> > commit e691d242d592a8556e25659fb091a2031abee4c9
> > Author: Lukáš Lalinský <lukas at oxygene.sk>
> > Date: Wed Sep 3 22:53:55 2014 +0200
> >
> > xcb: Initialize font options from Xft resources
> >
> > There is a similar code in the Xlib backend. The logic here is the
> > same, but
> > XCB doesn't support X resources directly, so there is some custom code
> > to get and parse the resources from the root window.
> >
> > Signed-off-by: Lukáš Lalinský <lukas at oxygene.sk>
> > Reviewed-by: Uli Schlachter <psychon at znc.in>
> >
> > The attached patch makes these tests pass again. Both hunks are required.
> > The
> > first one fixes a shameful oversight (whoops), the second one effectively
> > reverts the above patch, which is not what we want.
> >
> > Something is merging font options wrongly? Why does this code work for
> > cairo-xlib? I don't know...
> >
> > For the xlib backend: Are you running with --enable-xlib-xcb? Aka "are you
> > testing xlib at all?".
> >
> > Not much time right now (or in the near future), so can't look too closely
> > into this
> >
> > Cheers,
> > Uli
> > --
> > “I’m Olaf and I like warm hugs.”
> >
More information about the cairo
mailing list