[cairo] [PATCH 1/2] Don't return NULL to clients when getting image

Chris Wilson chris at chris-wilson.co.uk
Mon Sep 22 23:26:51 PDT 2014


On Mon, Sep 22, 2014 at 03:50:25PM -0700, Bryce Harrington wrote:
> diff --git a/src/win32/cairo-win32-surface.c b/src/win32/cairo-win32-surface.c
> index 7cd46fc..f11cbd8 100644
> --- a/src/win32/cairo-win32-surface.c
> +++ b/src/win32/cairo-win32-surface.c
> @@ -188,7 +188,7 @@ cairo_surface_t *
>  cairo_win32_surface_get_image (cairo_surface_t *surface)
>  {
>      if (surface->backend->type != CAIRO_SURFACE_TYPE_WIN32)

This is still dangerous - error surfaces have no surface->backend to
dereference.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the cairo mailing list