[cairo] Potential patches (need review help)
Bryce Harrington
bryce at osg.samsung.com
Tue Sep 23 13:16:46 PDT 2014
Hi all,
I've been combing through patches being contributed via the mailing
list, and pulled in several good ones.
Here are a few others on my list, that I think look really close but I
had some questions on (and can't test myself due to hardware).
https://bugs.freedesktop.org/show_bug.cgi?id=30610
This fixes an issue on Sun by declaring some anonymous unions. This is
probably fine but the bug's old so I'm not sure the patch is still
relevant.
https://bugs.freedesktop.org/show_bug.cgi?id=30969
Simple fix for windows zip file generation to include cairo-gobject
libraries. Another relatively old patch that I can't tell if it's still
relevant. The patch needs a (simple) modification to check for
existance of the library files.
https://bugs.freedesktop.org/show_bug.cgi?id=63461
Another platform endianness bug. The original patch looked simple
enough, but it's been superseded by two new patches that add NULL/0
checks. Do these two patches cover all the cases that the first patch
did? Or is there a simpler way to handle this without peppering these
checks everywhere?
https://bugs.freedesktop.org/attachment.cgi?id=77338
Excludes sphinx for windows builds. The patch is fine, but I'm
wondering: What is sphinx, some sort of search server? What are we
using it for? (See also fdo #29319 for another sphinx build patch).
Thanks ahead of time for opinions/feedback/concerns on any of the above.
Bryce
More information about the cairo
mailing list