[cairo] [PATCH] test: Always use DejaVu Sans as default font
bryce at osg.samsung.com
Mon Jul 6 14:24:54 PDT 2015
On Thu, Jul 02, 2015 at 11:52:15AM +0200, Andrea Canciani wrote:
> On Thu, Jul 2, 2015 at 12:05 AM, Lawrence D'Oliveiro <
> ldo at geek-central.gen.nz> wrote:
> > On Wed, 1 Jul 2015 12:00:49 +0200, Andrea Canciani wrote:
> > > This change should not affect Linux environments, assuming that the
> > > default font is already set to "DejaVu Sans".
> > On Linux environments, I would expect to see Fontconfig in use. This
> > can take a generic name like “Sans Serif” and map it to whatever font
> > the user desires.
> Yes, but (for the test suite) if this happens you are likely already
> getting failures when you test cairo, because unless the user-chosen font
> glyphs have the same shape as the DejaVu Sans ones, the output of the test
> cases will not match the reference.
> Please notice that most tests already set the font to
> CAIRO_TEST_FONT_FAMILY " ...".
Right, for the test suite, there is no user to have desires. :-)
Goal is to just make sure results match up to the references.
I don't know much about quartz but your four patches seem
sensible and straightforward enough. The change to DejaVu Sans I agree
probably won't have any effect on Linux, but I'd like to doublecheck
that before landing the patchset. Other than that, for all four
Reviewed-by: Bryce Harrington <bryce at osg.samsung.com>
More information about the cairo