[cairo] [PATCH 2/3] Support a different pixel format for HDC

[LRN]

On 17.04.2014 13:46, LRN wrote:
> On 17.04.2014 13:48, Uli Schlachter wrote:
>> On 17.04.2014 11:06, LRN wrote:
>>> Add cairo API to set up a Win32 surface for an HDC with an alpha channel.
>>
>> This adds alpha support to cairo-win32, but doesn't add support for this to the
>> test suite. IMO this should also contain the necessary changes to boilerplate/
>> and contain some information about the test suite results (and compare it to
>> cairo-win32-without-alpha?).
> 
> Yes, that would be awesome.
> 
>>
>>> Signed-off-by: Bas Schouten <bas.schouten at live.nl>
>>
>> I just noticed that your three patches are all signed off by different persons.
>> None of these is you.
> 
> No, one of them is actually from me (the third patch, unsurprisingly).
> 
>> What's up with this? Are we really sure that the original
>> authors are OK with submitting this code to cairo? Why didn't they do so
>> themselves? Where did you find the patches?
> 
> Patch #1 is from cairo bugzilla, see the link you gave me in [1].
> 
> Patch #2 (this patch) was used by Mozilla[2] back in 2010. They have [had?]
> internal copy of cairo to patch, so maybe they just haven't bothered with
> submitting it. Or maybe they did submit it to cairo bugzilla and it got lost
> there. Who knows? Either way, the patch is trivial enough, so i wouldn't
> worry about this one too much.
> 
> 
> [1] http://lists.cairographics.org/archives/cairo/2014-April/025148.html
> [2] https://bugzilla.mozilla.org/show_bug.cgi?id=577200
> 

Any progress on this?

The fallback surface-related crash was fixed in 0.14, so the patch labeled "Enlarge fallback surface" is no longer necessary. I would only need this patch ("Support a different pixel format for HDC") and at least one bit from "Adjust assertions and checks to handle more pixel formats".

These patches are very small, the only prerequisite for being able to evaluate them is understanding of cairo and W32 API. I'd very much like to stop patching cairo and push Windows RGBA code into GTK.

-- 
O< ascii ribbon - stop html email! - www.asciiribbon.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0x922360B0.asc
Type: application/pgp-keys
Size: 1717 bytes
Desc: not available
URL: <http://lists.cairographics.org/archives/cairo/attachments/20150310/3304af3e/attachment.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.cairographics.org/archives/cairo/attachments/20150310/3304af3e/attachment.sig>