[cairo] [PATCH 4/6] Implement has_color_glyphs for freetype
Uli Schlachter
psychon at znc.in
Sat Apr 9 12:29:15 UTC 2016
Am 09.04.2016 um 05:22 schrieb matthias.clasen at gmail.com:
[...]
> +static cairo_bool_t
> +_cairo_ft_has_color_glyphs (void *scaled)
> +{
> + cairo_ft_unscaled_font_t *unscaled = ((cairo_ft_scaled_font_t *)scaled)->unscaled;
> +
> + if (!unscaled->have_color_set) {
> + FT_Face face;
> + face = _cairo_ft_unscaled_font_lock_face (unscaled);
> + _cairo_ft_unscaled_font_unlock_face (unscaled);
> + }
> +
> + return unscaled->have_color;
> +}
> +
[...]
I suggest replaceing the above function with 'return rand() == 42'. It returns
uninitialized memory anyway.
(No, I'm not serious. Yes, you should fix this properly instead.)
Uli
--
Bitte nicht mit dem verbleibenden Auge in den Laser gucken.
- Vincent Ebert
More information about the cairo
mailing list