[cairo] xcb is passing, xlib? Re: What does it take to get a make check to pass with the xcb target, using CAIRO_REF_DIR?

[Uli Schlachter]

Am 23.07.2016 um 03:14 schrieb darxus at chaosreigns.com:
> On 07/23, Adrian Johnson wrote:
>> On 23/07/16 08:29, darxus at chaosreigns.com wrote:
>>> Adrian, did this work with the xlib target when you committed it?
>>
>> I only tested with image, pdf, and ps.
>>
>>> record-neg-extents is what's currently preventing the xlib target from
>>> passing, with regenerated references.
>>
>> I just ran that test with xcb. The output looks fine. There are just a
>> few pixel differences so probably just needs a ref image refresh.
> 
> xcb is passing for me (with regenerated references), but this test is doing
> weird (and inconsistent) things with xlib, with the current git master (on
> Xvfb): 3f8241f48488d3da4afce6646e043ee70cf1cfd2
> 
> http://www.chaosreigns.com/tmp/cairo/xlib/record-neg-extents-bounded.ref.png
> http://www.chaosreigns.com/tmp/cairo/xlib/record-neg-extents-bounded.xlib.argb32.out.png
> http://www.chaosreigns.com/tmp/cairo/xlib/record-neg-extents-bounded.xlib.rgb24.out.png
> 
> http://www.chaosreigns.com/tmp/cairo/xlib/record-neg-extents-unbounded.ref.png
> http://www.chaosreigns.com/tmp/cairo/xlib/record-neg-extents-unbounded.xlib.argb32.out.png
> http://www.chaosreigns.com/tmp/cairo/xlib/record-neg-extents-unbounded.xlib.rgb24.out.png

That looks great. We should definitely just re-generate the reference image. ;-)

> Anybody know why this doesn't run any tests?
> 
> $ DISPLAY=:5 CAIRO_TEST_TARGET=xlib ./cairo-test-suite -k record-neg-extents
> 
> While this runs all record* tests?
> 
> $ DISPLAY=:5 CAIRO_TEST_TARGET=xlib ./cairo-test-suite -k record

Because "-k" means "keyword" and these are not related to the name of the test.
For example in test/record-neg-extents.c:

CAIRO_TEST (record_neg_extents_unbounded,
	    "Paint unbounded recording pattern with untransformed extents outside of
target extents",
	    "record,transform,pattern", /* keywords */
	    NULL, /* requirements */
	    WIDTH, HEIGHT,
	    NULL, record_neg_extents_unbounded)

The first argument is the name of the test and the third argument is the list of
keywords.

If you just want to run a test directly, get rid of the -k:

$ DISPLAY=:5 CAIRO_TEST_TARGET=xlib ./cairo-test-suite record-neg-extents

Uli
-- 
"Every once in a while, declare peace. It confuses the hell out of your enemies"
 - 79th Rule of Acquisition