[cairo] Troublesome C99 ?

Antonio Ospite ao2 at ao2.it
Fri Dec 8 09:02:57 UTC 2017


On Tue, 05 Dec 2017 10:51:50 +0000
John Emmas <john at creativepost.co.uk> wrote:

> Hi there,
> 
> This morning I noticed this change in git master (which produces a 
> syntax error now when compiling with MSVC):-
> 
[...]
> // In 'src/cairo-svg-surface.c' :-
>      static const char * _cairo_svg_unit_strings[] =
>      {
>          [CAIRO_SVG_UNIT_USER] = "",  // <--- error occurs here !!
[...]
> 
> I think it's ( possibly? ) C99, which MSVC never fully supported :-(
> 

This was me, I assumed using C99 initializers was OK.
If it's not then the attached patch fixes this.

Should I send it over to bugzilla?

BTW when compilation fails it is generally a good idea to report the
exact message from the compiler.

Ciao,
   Antonio

-- 
Antonio Ospite
https://ao2.it
https://twitter.com/ao2it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-svg-fix-compilation-with-MSVC-which-doesn-t-support-.patch
Type: text/x-diff
Size: 1342 bytes
Desc: not available
URL: <https://lists.cairographics.org/archives/cairo/attachments/20171208/52e4b837/attachment.patch>


More information about the cairo mailing list