[cairo] [PATCH 1/2] Fix warning: '*' in boolean context

Uli Schlachter psychon at znc.in
Sat Dec 23 13:16:07 UTC 2017


The full message is:

  warning: ‘*’ in boolean context, suggest ‘&&’ instead
      _cairo_malloc((unsigned) (a) * (unsigned) (size)))
                                   ^
  note: in definition of macro ‘_cairo_malloc’
      ((size) ? malloc((unsigned) (size)) : NULL)
        ^~~~

Signed-off-by: Uli Schlachter <psychon at znc.in>
---
 src/cairo-malloc-private.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/cairo-malloc-private.h b/src/cairo-malloc-private.h
index 1e2c67f8d..570f7cb0e 100644
--- a/src/cairo-malloc-private.h
+++ b/src/cairo-malloc-private.h
@@ -60,7 +60,7 @@
  **/
 
 #define _cairo_malloc(size) \
-   ((size) ? malloc((unsigned) (size)) : NULL)
+   ((size) > 0 ? malloc((unsigned) (size)) : NULL)
 
 /**
  * _cairo_malloc_ab:
-- 
2.15.1



More information about the cairo mailing list