[cairo] [PATCH] pdf: Fix wrong cairo_pdf_outline_flags_t item prefix

Kouhei Sutou kou at cozmixng.org
Wed Jan 4 14:47:09 UTC 2017


Hi,

cairo_pdf_outline_flags_t is defined as the following:

typedef enum _cairo_pdf_outline_flags {
    CAIRO_BOOKMARK_FLAG_OPEN   = 0x1,
    CAIRO_BOOKMARK_FLAG_BOLD   = 0x2,
    CAIRO_BOOKMARK_FLAG_ITALIC = 0x4,
} cairo_pdf_outline_flags_t;

cairo_pdf_outline_flags_t items use "CAIRO_BOOKMARK_FLAG_"
prefix. Other cairo_*_flags_t (cairo_text_cluster_flags_t)
uses capitalized type name ("CAIRO_TEXT_CLUSTER_FLAG_") as
prefix. How about using the same convention for
cairo_pdf_outline_flags_t?

It seems that the "CAIRO_BOOKMARK_FLAG_" prefix is wrongly
used. cairo_pdf_outline_flags_t was called
cairo_pdf_bookmark_flags_t in the initial implementation:
  https://lists.cairographics.org/archives/cairo/2016-June/027427.html


Thanks,
--
kou
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-pdf-Fix-wrong-cairo_pdf_outline_flags_t-item-prefix.patch
Type: text/x-patch
Size: 4161 bytes
Desc: not available
URL: <https://lists.cairographics.org/archives/cairo/attachments/20170104/74086c3b/attachment.bin>


More information about the cairo mailing list