[cairo] [PATCH] pthread-same-source: Refresh reference images

Bryce Harrington bryce at osg.samsung.com
Mon Apr 2 18:26:56 UTC 2018


On Sat, Mar 31, 2018 at 01:52:53PM +0200, Uli Schlachter wrote:
> I already did the same thing in commit 3e22a8580a804. That commit added
> a GENERATE_REFERENCE mode that does not use threads and used that for
> generating the reference image.
> 
> However, the above commit falls into the range between commits
> fb57ea13e04d and 3d94269bd4. The later commit reverts the earlier one,
> which changed the way that image downscaling works / is used.
> 
> This means that the reference image that were generated back then were
> broken. Thus, regenerating the images is the right thing to do.
> 
> Signed-off-by: Uli Schlachter <psychon at znc.in>

Seems reasonable.

Acked-by: Bryce Harrington <bryce at osg.samsung.com>

(It'd still be interesting to see further refinements on the downscaling
code, I'm sure there's still potential there for more optimization.
Hopefully some day someone can look again at the convolution filter
approach and see if it can get better integrated without causing
test failures.)

Pushed:
To ssh://git.freedesktop.org/git/cairo
   fba7a7c..50a6ad5  master -> master

> ---
>  test/reference/pthread-same-source.ref.png | Bin 1076 -> 1002 bytes
>  1 file changed, 0 insertions(+), 0 deletions(-)
> 
> diff --git a/test/reference/pthread-same-source.ref.png b/test/reference/pthread-same-source.ref.png
> index c1c186b9b8a5ac31c1c9aa5ce42f162c3e0f389e..92a86c2f6e9b89fd612baa7dd6d25f8af33bd78a 100644
> GIT binary patch
> literal 1002
> zcmeAS at N?(olHy`uVBq!ia0y~yU<5K58911L)MWvCLm<VL<n8Xl at E-&h>|H*Yfq{9x
> zr;B4q#hka-4JRIU5O6&>Q9zdYs-fYO)Di)nqak_|))+CfueYu`H)loK|83W#R at _Q|
> z_TvZJ7Qe60m;$!d|K>kn{*%FDGh at lFT!u?FjUJyFC!{gID7nqBq>^dkGiHUeY!_Z`
> zWAymUqI8zsVHWR#%el-Go^iU&;%_jKc36I!P2sF?hlxBxrdfmEc3y{B>H?W|43}~k
> z=H^K^nD{GPs$p0XEB&BOD06O>c!P=Z3=<#;(#HxkSm7*)yzsJ&5oo_hF^DYL6${dR
> zDF$K&NO1%4TGsJy=qvqq&Fbp!Gk?x~wiI6*40LQ72!T9gb=M5&OsGr2{uqK%zt8N6
> ztN)(AHux<t4zL9FO^7$=IV_<{tX^l^G2bO>`7K~Xai~!{x<ILf#2BVf%a-qK7T118
> nzYdu%{@}Tx`C4b%r;q;@lYN%0`rIY~%)AVqu6{1-oD!M<vdew`
> 
> literal 1076
> zcmeAS at N?(olHy`uVBq!ia0y~yU<5K58911L)MWvCLm<VL<n8Xl at E-&h>|H*Yfr0s@
> zr;B4q#hkZy75!urCE70L*LAOco0Ruz*P5FGoYn_SeQ!8k^%eGU<yExEJL=<6-cWHa
> z at O;BTpM900xA(ng4$V%}`@fetYI#*Lqek at nzw8InKQT>6V}4O`n_<aM7NxV?4zqX{
> zT+U^l at JzVFM4utktif+Pufr^Vg-d%FmfU2px@*ReY1ioSnRrcer5`+=?D0BeH^UOi
> zgG+WoOwj|H%#aBpf#!qkbeILP`7Oxc3C|$L1GU^_AYMyZUc=u_^5=n`J9}n(WzC$)
> z*H&(0^w<nSCA)GN=H^K^n1GPO^4n||UJgmAEvClxadmgLeSaMJIwb%1zWaIGb8q*>
> zXUu(NYAkPmb=NgusDh&m6o=qQ1;-gE62Y+wiD_UgLZTHc2vP=)SK>9^nl<zF*N0WL
> z7W20HZ3RZ$e?d1Y#2?6U*rPl<ZQlKN^?z%ufcAZzHS_w<YV-a5KwoFkBSx*w58O_*
> zhuEzD`RngFTl}^H(<=xeg)$^_K!cTXslUu8{4P#o4{6H-76S~Pu6{1-oD!M<66(JT
> 
> -- 
> 2.16.2
> 
> -- 
> cairo mailing list
> cairo at cairographics.org
> https://lists.cairographics.org/mailman/listinfo/cairo


More information about the cairo mailing list