[cairo] [PATCH v2 1/5] cairo-trace: Simplify bigendian case in emit_image.
Maarten Lankhorst
maarten.lankhorst at linux.intel.com
Mon Aug 6 14:59:27 UTC 2018
All the cases are the same, except len is different.
Use the already calculated len parameter to handle all
cases except RGB24 the same.
Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Suggested-by: Bryce Harrington <bryce at bryceharrington.org>
---
util/cairo-trace/trace.c | 25 +++++--------------------
1 file changed, 5 insertions(+), 20 deletions(-)
diff --git a/util/cairo-trace/trace.c b/util/cairo-trace/trace.c
index 87b2df46ef09..7a43b0f2c341 100644
--- a/util/cairo-trace/trace.c
+++ b/util/cairo-trace/trace.c
@@ -1680,24 +1680,6 @@ _emit_image (cairo_surface_t *image,
#ifdef WORDS_BIGENDIAN
switch (format) {
- case CAIRO_FORMAT_A1:
- for (row = height; row--; ) {
- _write_data (&stream, data, (width+7)/8);
- data += stride;
- }
- break;
- case CAIRO_FORMAT_A8:
- for (row = height; row--; ) {
- _write_data (&stream, data, width);
- data += stride;
- }
- break;
- case CAIRO_FORMAT_RGB16_565:
- for (row = height; row--; ) {
- _write_data (&stream, data, 2*width);
- data += stride;
- }
- break;
case CAIRO_FORMAT_RGB24:
for (row = height; row--; ) {
int col;
@@ -1709,10 +1691,13 @@ _emit_image (cairo_surface_t *image,
data += stride;
}
break;
+ case CAIRO_FORMAT_A1:
+ case CAIRO_FORMAT_A8:
+ case CAIRO_FORMAT_RGB16_565:
case CAIRO_FORMAT_RGB30:
case CAIRO_FORMAT_ARGB32:
for (row = height; row--; ) {
- _write_data (&stream, data, 4*width);
+ _write_data (&stream, data, len);
data += stride;
}
break;
@@ -1777,7 +1762,7 @@ _emit_image (cairo_surface_t *image,
int col;
for (col = 0; col < width; col++)
dst[col] = bswap_32 (src[col]);
- _write_data (&stream, rowdata, 4*width);
+ _write_data (&stream, rowdata, len);
data += stride;
}
break;
--
2.18.0
More information about the cairo
mailing list