[cairo] MR of cpp-conditionals for legacy FreeType2 without color font support

suzuki toshiya mpsuzuki at hiroshima-u.ac.jp
Thu Dec 13 06:07:11 UTC 2018


Dear Behdad,

Sorry for lated response to 3ec4aa24 applied on 2018-07-16,
which makes cairo use FreeType2's color font feature always.

For older FreeType2 users, I wrote a patch and merge request:

https://gitlab.freedesktop.org/cairo/cairo/merge_requests/8

I want to ask a question - you removed "#ifdef FT_LOAD_COLOR"
... "#endif" for the code depending FT_PIXEL_MODE_BGRA, like
this:

@@ -1275,7 +1289,6 @@ _get_bitmap_surface (FT_Bitmap                 *bitmap,
            component_alpha = TRUE;
        }
        break;
-#ifdef FT_LOAD_COLOR
     case FT_PIXEL_MODE_BGRA:
        stride = width * 4;
        if (own_buffer) {
@@ -1298,7 +1311,6 @@ _get_bitmap_surface (FT_Bitmap                 *bitmap,
        }
        format = CAIRO_FORMAT_ARGB32;
        break;
-#endif
     case FT_PIXEL_MODE_GRAY2:
     case FT_PIXEL_MODE_GRAY4:
     convert:

Does this change means that you want to consider the case
FT_LOAD_COLOR is missing but FT_PIXEL_MODE_BGRA is defined?

Regards,
mpsuzuki


More information about the cairo mailing list