[cairo] Fix a thinko in color glyph support

Petr Kobalíček kobalicek.petr at gmail.com
Sun Jul 14 15:13:48 UTC 2019


  - else branch is redundant, utf8_copy is already NULL
  - malloc result should be checked and if NULL status should be changed to
  - ideally a small static buffer should be used for small strings to avoid

I'm not a cairo dev so it's just what I would have done.

On Sun, Jul 14, 2019 at 4:45 PM Matthias Clasen <matthias.clasen at gmail.com>

> On Fri, May 31, 2019 at 9:59 AM Matthias Clasen <matthias.clasen at gmail.com>
> wrote:
>> I've spent some time tracking down a GTK+ / Pango crash (
>> https://gitlab.gnome.org/GNOME/pango/issues/346 ).
>> Turns out that there was a thinko in our original color glyph patch. We
>> can't modify the passed-in text.
>> Here is a quick fix:
>> https://github.com/matthiasclasen/cairo/commit/79ad01724161502e8d9d2bd384ff1f0174e5df6e
>> This probably needs to go into a stable cairo branch too.
> Hi, two months on, this is still not in git. It is a very easy memory
> corruption patch.
> We ship the patch in Fedora, but I would prefer to not rely on distros to
> pick through
> the rubble. Can we get this merged, please ?
> --
> cairo mailing list
> cairo at cairographics.org
> https://lists.cairographics.org/mailman/listinfo/cairo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.cairographics.org/archives/cairo/attachments/20190714/1dd782e8/attachment.html>

More information about the cairo mailing list