[cairo] color emoji support broken

suzuki toshiya mpsuzuki at hiroshima-u.ac.jp
Fri May 31 03:02:49 UTC 2019


Dear Matthias,

Ahhh, I'm quite sorry. Using "ifdef" is not good to check the availability of
FT_PIXEL_MODE_BGRA.
This is an integer value declared as

  typedef enum  FT_Pixel_Mode_
  {
    FT_PIXEL_MODE_NONE = 0,
    FT_PIXEL_MODE_MONO,
    FT_PIXEL_MODE_GRAY,
    FT_PIXEL_MODE_GRAY2,
    FT_PIXEL_MODE_GRAY4,
    FT_PIXEL_MODE_LCD,
    FT_PIXEL_MODE_LCD_V,
    FT_PIXEL_MODE_BGRA,

    FT_PIXEL_MODE_MAX      /* do not remove */

  } FT_Pixel_Mode;

#ifdef is not good. Soon I would post a fix for that, by better configure script.

Regardss,
mpsuzuki

suzuki toshiya wrote:
> Dear Mattias,
> 
> Maybe this commit?
> 
> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcgit.freedesktop.org%2Fcairo%2Fcommit%2F%3Fid%3Dc0ed8ce1a111cb9472aef080ac3aa31526443f7c&data=02%7C01%7Cmpsuzuki%40hiroshima-u.ac.jp%7C370c41fa9ec24bea61fa08d6e55edbd4%7Cc40454ddb2634926868d8e12640d3750%7C1%7C0%7C636948592938855752&sdata=Lu7OP1FjZ53Wii9fBIPIftfL0vkReqMVav53MgX1Ik8%3D&reserved=0
> 
> Sorry, please let me know more about your trouble.
> 
>> This breaks color Emoji support since the freetype headers don't define this.
> 
> If so, and if we revert this, following "case FT_PIXEL_MODE_BGRA" would cause a compilation error?
> 
> Regards,
> mpsuzuki
> 
> On 2019/05/31 2:09, Matthias Clasen wrote:
>> Some recent commit introduced an
>>
>> #ifdef FT_PIXEL_MODE_BGRA
>>
>> This breaks color Emoji support since the freetype headers don't define this.
>>
>> Please revert
>>
> 


More information about the cairo mailing list