There's no need for a follow-up patch. <div class="gmail_extra"> <div class="gmail_quote">On Aug 31, 2016 2:42 PM, "Olivier Blin" <<a href="mailto:olivier.blin@softathome.com">olivier.blin@softathome.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thank you all for the review. Adrian, do you want to send a follow-up patch to error out if libz is missing? Or should I do it? Cheers Le 31/08/2016 à 23:36, Bryce Harrington a écrit : <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> On Tue, Aug 30, 2016 at 04:37:49PM -0700, Behdad Esfahbod wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Adrian is right. Original patch lgtm. </blockquote> Thanks. I'll interpret that as an acked-by if you don't mind, and go ahead and land it. Pushed: 1057487..35a1761 master -> master Bryce <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> (i just remembered how much fun I had writing those macros...:-) On Aug 30, 2016 3:28 PM, "Adrian Johnson" <<a href="mailto:ajohnson@redneon.com" target="_blank">ajohnson@redneon.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> On 31/08/16 06:38, Bryce Harrington wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> On Fri, Aug 12, 2016 at 03:48:57PM +0200, Olivier Blin wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Le 12/08/2016 à 15:08, Enrico Weigelt, metux IT consult a écrit : <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> On 12.08.2016 11:04, Olivier Blin wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Looks like this would silently disable the script backend if libz is missing. IMHO, a very bad idea - instead it should break with a proper error message. </blockquote> This is actually copy/paste of what is already properly done for the PostScript and PDF backends. CAIRO_ENABLE_SURFACE_BACKEND(pdf, PDF, yes, [ # The pdf backend requires zlib. use_pdf=$have_libz pdf_NONPKGCONFIG_LIBS=-lz ]) </blockquote> Right, there seems to be the same problem. I'd suggest emitting an error here. </blockquote> Ok, but this is a separate issue that was already present in the previous configure file. This can be fixed regardless of this patch. Thanks for your input </blockquote> Would you mind sending a 2-patch set that fixes both issues for us? </blockquote> There is no problem with this patch. <a href="https://lists.cairographics.org/archives/cairo/2016-August/027701.html" rel="noreferrer" target="_blank">https://lists.cairographics.org/archives/cairo/2016-August/027701.html</a> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Thanks, Bryce <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> -- Olivier Blin - SoftAtHome -- cairo mailing list <a href="mailto:cairo@cairographics.org" target="_blank">cairo@cairographics.org</a> <a href="https://lists.cairographics.org/mailman/listinfo/cairo" rel="noreferrer" target="_blank">https://lists.cairographics.org/mailman/listinfo/cairo</a> </blockquote></blockquote> -- cairo mailing list <a href="mailto:cairo@cairographics.org" target="_blank">cairo@cairographics.org</a> <a href="https://lists.cairographics.org/mailman/listinfo/cairo" rel="noreferrer" target="_blank">https://lists.cairographics.org/mailman/listinfo/cairo</a> </blockquote></blockquote></blockquote> -- Olivier Blin - SoftAtHome </blockquote></div></div>