<div dir="ltr">On Fri, Jan 20, 2017 at 10:20 PM, Bryce Harrington <span dir="ltr"><<a href="mailto:bryce@osg.samsung.com" target="_blank">bryce@osg.samsung.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">On Wed, Jan 18, 2017 at 03:29:55PM +0100, Andrea Canciani wrote:<br>
> The wip/restore-10.4 was updated to actually work on 10.4 with the help of<br>
> G 3.<br>
> I also manged to set up a virtual machine running OSX 10.4, so I will now<br>
> be able to check for regressions when updating new patches for cairo-quartz.<br>
> Given that there seems to still be some interest in keeping 10.4 working<br>
> and that the code is already available, I would go for it and merge<br>
> <a href="https://cgit.freedesktop.org/%7Eranma42/cairo/commit/?h=wip/restore-10.4&id=5a8a9c97ed268004cbac510d39739ff56c0fb43c" rel="noreferrer" target="_blank">https://cgit.freedesktop.org/~<wbr>ranma42/cairo/commit/?h=wip/<wbr>restore-10.4&id=<wbr>5a8a9c97ed268004cbac510d39739f<wbr>f56c0fb43c</a><br>
><br>
> Bryce, does this sound like a reasonable plan?<br>
<br>
</span>Yes, that sounds fine.  I looked up the past discussions for the<br>
rationale we'd had for upping the version requirement to 10.5:<br>
<br>
    <a href="https://lists.cairographics.org/archives/cairo/2014-November/025792.html" rel="noreferrer" target="_blank">https://lists.cairographics.<wbr>org/archives/cairo/2014-<wbr>November/025792.html</a><br>
    <a href="https://lists.cairographics.org/archives/cairo/2015-February/025949.html" rel="noreferrer" target="_blank">https://lists.cairographics.<wbr>org/archives/cairo/2015-<wbr>February/025949.html</a><br>
<br>
The main issue seems to have been testing on 10.4, which sounds like you<br>
now have resolved to your satisfaction.  We were also uncertain whether<br>
maintaining support for such an old version was worth the effort, but<br>
there's been ample interest voiced by users, so bringing it back does<br>
seem like it would provide tangible value.<br></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
My only question is, I recall you mentioned there were other code<br>
cleanups that would be made possible by dropping the 10.4 requirement?<br>
If those cleanups were performed, then they may need to be revisited in<br>
light of this change.<br></blockquote><div><br></div><div>The cleanups were ready (in the <a href="https://cgit.freedesktop.org/~ranma42/cairo/log/?h=wip/remove-10.4">https://cgit.freedesktop.org/~ranma42/cairo/log/?h=wip/remove-10.4</a> branch) but they have not been merged into master<br>The changes are sufficient to fix the compile-time errors and to bring cairo-quartz on 10.4 basically on par with cairo on modern (10.11) releases (I found that the older version of quartz is slightly more prone to some numerical approximation and instability issues, but the test suite does not show any major regression).<br></div><div><br>In fact the patch has already been merged in Tigerbrew (a fork of Homebrew aimed at supporting older OSX releases):<br><a href="https://github.com/mistydemeo/tigerbrew/commit/071470409272b955b10e6041c94be6539e11b24f">https://github.com/mistydemeo/tigerbrew/commit/071470409272b955b10e6041c94be6539e11b24f</a><br><br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">
> If there are no concerns, I will proceed with this before working on some<br>
> test failures that were uncovered by the record-replay-extend.c test<br>
> (Quartz does not handle correctly bounded recording surfaces).<br>
><br>
> Andrea<br>
<br>
</span>Sounds good, thanks for following up on this.<br>
<span class="gmail-HOEnZb"><font color="#888888"><br>
Bryce<br>
</font></span></blockquote></div><br></div><div class="gmail_extra">Awesome, tomorrow I will do the merge :)<br><br></div><div class="gmail_extra">Andrea<br></div></div>