<div dir="ltr">I meant <span style="font-size:12.8px">`</span><span style="font-size:12.8px;color:rgb(0,0,0);white-space:pre-wrap">cairo_format_stride_for_<wbr>width()` has no knowledge about the height.</span></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Mar 9, 2017 at 5:23 PM, Petr Kobalíček <span dir="ltr"><<a href="mailto:kobalicek.petr@gmail.com" target="_blank">kobalicek.petr@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Since `<span style="color:rgb(0,0,0);white-space:pre-wrap">cairo_format_stride_for_<wbr>width()` has no knowledge about the width it cannot return -1 in case that stride * height would overflow. I think this must be checked.</span></div><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Thu, Mar 9, 2017 at 12:01 PM, Adrian Johnson <span dir="ltr"><<a href="mailto:ajohnson@redneon.com" target="_blank">ajohnson@redneon.com</a>></span> wrote:<br></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">I wrote this patch [1] for bug 98165 last year. I found it is also<br>
needed to fix a poppler bug [2]. Any objections to pushing it?<br>
<br>
[1] <a href="https://bugs.freedesktop.org/show_bug.cgi?id=98165#c6" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/s<wbr>how_bug.cgi?id=98165#c6</a><br>
[2] <a href="https://bugs.freedesktop.org/show_bug.cgi?id=100056" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/s<wbr>how_bug.cgi?id=100056</a><br>
<br>
<br></div></div><span class="HOEnZb"><font color="#888888">--<br>
cairo mailing list<br>
<a href="mailto:cairo@cairographics.org" target="_blank">cairo@cairographics.org</a><br>
<a href="https://lists.cairographics.org/mailman/listinfo/cairo" rel="noreferrer" target="_blank">https://lists.cairographics.or<wbr>g/mailman/listinfo/cairo</a><br></font></span></blockquote></div><br></div>
</blockquote></div><br></div>